Add test for boolean contract with extra message argument (#945)

This just tests an additional scenario; no logic changes.
uber · Mar 26, 2024 · ce892d7 · ce892d7
1 parent 83e0149
commit ce892d7
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/nullaway/src/test/java/com/uber/nullaway/NullAwayContractsBooleanTests.java b/nullaway/src/test/java/com/uber/nullaway/NullAwayContractsBooleanTests.java
@@ -19,6 +19,10 @@ public void nonNullCheckIsTrueIsNotNullable() {
             "    Validation.checkTrue(o1 != null);",
             "    return o1.toString();",
             "  }",
+            "  String test1WithMsg(@Nullable Object o1) {",
+            "    Validation.checkTrue(o1 != null, \"o1 should not be null!\");",
+            "    return o1.toString();",
+            "  }",
             "  String test2(Map<String, String> map) {",
             "    Validation.checkTrue(map.get(\"key\") != null);",
             "    return map.get(\"key\").toString();",
@@ -553,6 +557,10 @@ private CompilationTestHelper helper() {
             "  static void checkTrue(boolean value) {",
             "    if (!value) throw new RuntimeException();",
             "  }",
+            "  @Contract(\"false, _ -> fail\")",
+            "  static void checkTrue(boolean value, String msg) {",
+            "    if (!value) throw new RuntimeException(msg);",
+            "  }",
             "  @Contract(\"true -> fail\")",
             "  static void checkFalse(boolean value) {",
             "    if (value) throw new RuntimeException();",