Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Error Prone 2.32.0 #1037

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Update to Error Prone 2.32.0 #1037

merged 1 commit into from
Sep 12, 2024

Conversation

msridhar
Copy link
Collaborator

Error Prone 2.32.0 requires JDK 17 or higher. We tweak our CI config accordingly, adding a job testing on the last EP version (2.31.0) that worked with JDK 11. (We should really tweak our Gradle config to completely divorce the JDK version used to run Gradle from the JDK version for the test tasks, but that'll have to wait for a PR.)

A few changes to our required job names will be required before this can land.

@msridhar msridhar requested a review from yuxincs September 11, 2024 20:33
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (66225fd) to head (d69eae3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1037   +/-   ##
=========================================
  Coverage     87.23%   87.23%           
  Complexity     2129     2129           
=========================================
  Files            83       83           
  Lines          6965     6965           
  Branches       1356     1356           
=========================================
  Hits           6076     6076           
  Misses          458      458           
  Partials        431      431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar merged commit e4dc1ad into master Sep 12, 2024
11 checks passed
@msridhar msridhar deleted the ep-2.32.0 branch September 12, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants