JSpecify: Handle @Nullable assignments to @Nonnull arrays

[armughan11]

Handles cases in JSpecify mode where a @Nullable element is assigned to an unannotated array. Added relevant unit tests.

Current Behavior

Both are valid assignments.

String [] foo = new String[10];
@Nullable String [] bar = new String [10];
foo[1] = null;
bar[1] = null;

New Behavior

Assignment to foo generates an error since array elements are @Nonnull.

String [] foo = new String[10];
@Nullable String [] bar = new String [10];
foo[1] = null;
bar[1]=null;

[msridhar]

Awesome! I have a couple of comments but this looks great

[msridhar]

We need a more appropriate message here, like "Writing @Nullable expression into array with @NonNull contents". Also you should use the ErrorBuilder APIs and add a new ErrorMessage message type.

[armughan11]

Fixed!

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.07%. Comparing base (1c497a7) to head (bdb8f10).

Files	Patch %	Lines
...away/src/main/java/com/uber/nullaway/NullAway.java	84.61%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #929      +/-   ##
============================================
- Coverage     87.07%   87.07%   -0.01%     
- Complexity     1991     1994       +3     
============================================
  Files            77       77              
  Lines          6430     6444      +14     
  Branches       1246     1249       +3     
============================================
+ Hits           5599     5611      +12     
  Misses          422      422              
- Partials        409      411       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[msridhar]

Looking great! Just a couple more things

[msridhar]

LGTM, thanks for the contribution!