Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is work to resolve the issue described in #717.
Types of changes
What types of changes does your code introduce to CausalML?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
A variety of errors arise when currently building as described in #717, this PR resolves those errors. Errors were due to non-existent keys from two sources:
get_cumgain
looking for a treatment_effect_col named "tau" by default, but the treatment effect column being passed was called "treatment_effect_col" without supplying the new name as an argument to the functiontest_causal_trees.py
were due to indexing the wrong element of what is returned byqini_score(...)
Starting this PR to see how it builds on the uber fork and will resolve issues as required.