Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/717 pytest tau col hotfix #719

Closed
wants to merge 1 commit into from

Conversation

ras44
Copy link
Collaborator

@ras44 ras44 commented Nov 28, 2023

Proposed changes

This is work to resolve the issue described in #717.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

A variety of errors arise when currently building as described in #717, this PR resolves those errors. Errors were due to non-existent keys from two sources:

  • most errors were due to visualization functions like get_cumgain looking for a treatment_effect_col named "tau" by default, but the treatment effect column being passed was called "treatment_effect_col" without supplying the new name as an argument to the function
  • errors in test_causal_trees.py were due to indexing the wrong element of what is returned by qini_score(...)

Starting this PR to see how it builds on the uber fork and will resolve issues as required.

@ras44 ras44 requested a review from jeongyoonlee November 29, 2023 16:37
@ras44 ras44 force-pushed the dev/717_pytest_tau_col_hotfix branch from c80cab6 to 614cb2b Compare November 29, 2023 17:13
@ras44
Copy link
Collaborator Author

ras44 commented Nov 29, 2023

closing for now as I need to debug this further

@ras44 ras44 closed this Nov 29, 2023
@ras44 ras44 deleted the dev/717_pytest_tau_col_hotfix branch November 29, 2023 20:43
@ras44 ras44 restored the dev/717_pytest_tau_col_hotfix branch November 29, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants