Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #796 remove dep on pygam, use IsotonicRegression #803

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ras44
Copy link
Collaborator

@ras44 ras44 commented Nov 9, 2024

Proposed changes

This removes the dependency on pygam and replaces the use of LogisticGAM() in causalml/propensity.py : calibrate() with IsotonicRegression(). Work shown here supports that using IsotonicRegression() produces comparable or improves log-loss and brier score loss values.

This removes the pygam dependency, which is acting as a constraint on other dependencies.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@jeongyoonlee
Copy link
Collaborator

Thanks for the quick turnaround, @ras44. The test is failing, I guess, because the new calibrated propensity contains 0 or 1. Propensity scores, or treatment probabilities, should be within (0, 1), excluding 0 or 1, and binomial-like outputs are not ideal.

@ras44 ras44 requested a review from jeongyoonlee November 14, 2024 22:12
@jeongyoonlee
Copy link
Collaborator

jeongyoonlee commented Nov 14, 2024

I'm reposting my message from Slack. ICYMI: In your example notebook, treatment is supposed to be assigned randomly with a 75% probability. So, the logistic regression propensity and PyGAM calibrated scores look better than other calibrated scores, which show binomial distributions.

For a more interesting test, we should try a propensity model, of which outputs are not probabilities, e.g., GBM or RF, and then see how PyGAM calibration changes the distribution and find the calibration method that generates similar outputs.

A simple logistic regression - or sigmoid transformation might work better.

@ras44
Copy link
Collaborator Author

ras44 commented Nov 15, 2024

My apologies! Too many windows open and notifications turned off :) Will take a more detailed look at it and hopefully make it to the call tomorrow 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants