Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CausalTree's base _tree module with sklearn 1.15.2 #806

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jeongyoonlee
Copy link
Collaborator

Proposed changes

This PR updates CausalTree's base _tree module with sklearn==1.15.2, which adds support for the missing value and other improvements.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@jeongyoonlee jeongyoonlee added the enhancement New feature or request label Dec 6, 2024
@jeongyoonlee jeongyoonlee marked this pull request as ready for review December 13, 2024 17:04
@jeongyoonlee
Copy link
Collaborator Author

Hi @alexander-pv. I've updated the _tree module with sklearn==1.15.2, which has native missing value support. Can you take a look when you have a chance? Thanks.

Copy link
Collaborator

@ras44 ras44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants