Fix Travis CI build. #547
Fix Travis CI build. #547
Conversation
|
Lol, why u check CLA on forks? |
|
Though I am talking to myself in a lonely fork… who am i to judge a bot doing its work… |
|
Oh damn, it's not my fork, apologies to everyone! (I specifically clicked "New PR" on my own fork to test PR before opening it against upstream) |
|
Also bump the buck version to bring in the fix for facebook/buck#1510 since it was causing failures on travis. |
|
would be great if you can bump the buckversion too |
.travis.yml
Outdated
| - echo $android_sdk_preview_license > $ANDROID_HOME/licenses/android-sdk-preview-license | ||
| - export ANDROID_HOME="$HOME"/android-sdk | ||
| - mkdir -p "$ANDROID_HOME" | ||
| - export ANDROID_SDK_FILE_NAME=sdk-tools-darwin-3859397.zip |
There was a problem hiding this comment.
why darwin? travis runs on linux right?
There was a problem hiding this comment.
ah, facepalm, now I'm curious how it works in other projects where I did same thing… I guess Android tooling is more or less crossplatform now, that's how you check that lol
|
Will update buck version separately |
|
Ahh, I haven't have time to fix absence of |
Cmon travis, just trigger the build damn it :/