Add rules to generate a thrift-gen release. #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tar -czf thrift-gen.tar.gz $(RELEASE) | ||
| mv thrift-gen.tar.gz $(RELEASE)/ | ||
|
|
||
|
|
||
| .PHONY: all help clean fmt format get_thrift install install_ci test test_ci vet |
There was a problem hiding this comment.
can you add release_thrift_gen to the .PHONY section
|
Cool, some minor comments, otherwise lgtm. |
|
Thanks for the comments. I changed the naming of the directories in the tarball a bit so they are in line with the release of thrift https://github.com/prashantv/thrift/releases. This makes the |
|
lgtm |
thanodnl
force-pushed
the
release-thrift-gen
branch
from
1e7bc80
to
ea283fc
Compare
|
Rebased on master for |
thanodnl
added a commit
that referenced
this pull request
Dec 30, 2015
Add rules to generate a thrift-gen release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test generated code on travis we need a version of
thrift-genavailable during ci. Before we usedgo get github.com/uber/tchannel-go/thrift/thrift-gento install a version there. But sincego getis unaware of the versions of dependencies used bythrift-genthis unexpectedly broke our tests.With these changes we can reliably generate a release tarball via
make release_thrift_genand upload it to github to create a release ofthrift-gen. We can then download a specific working binary ofthrift-genduring ci to test our code generation.Example usage:
For testing purposes I created an alpha release on https://github.com/thanodnl/tchannel-go/releases/tag/v0.1-alpha to test this on travis.