Add component tag to tracing spans #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenX1993
commented
Oct 7, 2024
| @@ -38,6 +38,8 @@ import ( | |||
| // NB: the string value is what's actually shared between implementations | |||
| const zipkinSpanFormat = "zipkin-span-format" | |||
|
|
|||
| const componentName = "tchannel-go" | |||
There was a problem hiding this comment.
Add -go suffix since we have tchannel library for java as well.
|
how was this tested end-to-end? |
If within the tchannel-go, there is already a tracing testing, and I updated the test with the new tag verification in this PR: Line 60 in af146f5 If internally in monorepo, once I have the diff to bump the tchannel-go version, I will use our testing service to test end-to-end in staging env - checking the tag from jaeger UI. |
cinchurge
approved these changes
Oct 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is making a minor change to add span component tag to tracing spans. According to the OpneTracing sematic conventions, the component tag indicates the library that created the spans. At Uber, It is quite useful for the tracing team to understand the span creation distribution among libraries in order to optimize the operational cost.