Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround to change the lang attribute on storybook #50

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Workaround to change the lang attribute on storybook #50

merged 1 commit into from
Apr 11, 2024

Conversation

jmblog
Copy link
Contributor

@jmblog jmblog commented Apr 11, 2024 •
edited
Loading

To render <html lang="ja"> on storybook.

Ref: storybookjs/storybook#11706

Before After
image image

@takanorip takanorip merged commit 10b0f3f into main Apr 11, 2024
2 checks passed
@takanorip takanorip deleted the lang-ja-on-storybook branch April 11, 2024 07:02
@8845musign
Copy link
Collaborator

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip approved these changes

@8845musign 8845musign Awaiting requested review from 8845musign 8845musign is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmblog @8845musign @takanorip