-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 'extra' akmod stream & facetimehd-kmod to akmod cache #163
Conversation
PR mulderje#5 in my fork passes all builds for f39 & f40. edit: to confirm this is now also building for f40. |
This is the initial commit of the facetimehd firmware for the integrated camera for older macbook air models.
7008d63
to
2d5bf64
Compare
One best practice, please don't force push, especially once feedback starts getting added to the PR. :-) It causes the loss of context. |
Good to know. I was having issues cleaning up some small commits and ended up doing something like Likewise when updating my fork is there a preferred git incantation to keep things merged/rebased? E.g. for this pr to pull in your updated, what would you do to update the branch/pr code? I had tried to do a sync in the UI then pull/rebase into my branch but it looks like that's not ideal either based on the way it showed up in the logs. |
Is there a way to re-kick the builds here? Looks like I had some failures due to the v4l2loopback module you are debugging. |
You just did it! I approved another build attempt. |
Doing a local rebase does necessitate at force push, so I would avoid it if possible.
Yeah I find GitHub's fork sync to be painful. The best solution I've found if you wish to use the web UI, make your fork, then do your dev work/modifications on a branch. Then you'll be able to use "sync fork" in UI to update, and merge from main into your dev branch without blowing away changes. Merges may conflict but you can fix, and some people don't like the merge commit logs, but do not despair, we squash merge PRs to avoid excessive logs, so no need to try to remove them in the PR itself. |
Thank you! Any other feedback on the PR or things you would like me to cover off on prior to getting this committed? Happy to work with you on a path towards getting this into your copr and I will at least try to get this into rpmfusion (never done before) on the side. |
Co-authored-by: Benjamin Sherman <benjamin@holyarmy.org>
feat: add facetimehd kmod and related files via install script Much of the build script taken from https://github.com/ublue-os/akmods/ while working through ublue-os/akmods#163
chore: break daily cron schedule into their own file
Revert "chore: break daily cron schedule into their own file"
FYI rebased this against #171 Build is successful in my fork at mulderje#5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ublue-os/akmods#163 (#1009) Co-authored-by: Kyle Gospodnetich <me@kylegospodneti.ch>
Copying the below from #158 which was auto-closed/merged since I didn't make the PR from a branch and main got synced. Wanted to also quickly confirm that
podman build -f Containerfile.common .
works locally with this PR, and appears to add in thefacetimehd-kmod
RPM.I have been working on getting an old MacBook Air fully running, and running into things like not being able to just copy firmware files into the base system... :)
One thing missing within the Fedora repos for me was the FacetimeHD Firmware. This led me down a path of creating the below. Please note this was my first time messing around with spec files/copr, and any feedback/suggestions would be much appreciated.
sudo rpm-ostree install akmod-facetimehd facetimehd-firmware
, which is already a huge improvementOpen questions:
Thanks!
Jon