chore: add proper kernel version to ostree.linux label #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyeCantCU
force-pushed
the
label-kernel-version
branch
from
685391e
to
82bfd6a
Compare
bsherman
commented
Apr 14, 2024
.github/workflows/reusable-build.yml
Outdated
| # Get kernel version with podman | ||
| container_name="fq-$(uuidgen)" | ||
| podman run --entrypoint /bin/bash --name "$container_name" -dt "${{ env.FQ_SOURCE_IMAGE }}" | ||
| installed_packages=$(podman exec "$container_name" rpm -qa) |
There was a problem hiding this comment.
this is pretty much what I was expecting to do...
except, i think run podman exec "$container_name" rpm-ostree install dnf
and also to add the appropriate repo for asus, fsync or surface kernel flavors...
which then will allow podman exec "$container_name" dnf search kernel and you can get the "would be installed version" (in case of surface its' kernel-surface not kernel).
Signed-off-by: RJ Trujillo <eyecantcu@pm.me>
EyeCantCU
force-pushed
the
label-kernel-version
branch
from
82bfd6a
to
c49b93c
Compare
Signed-off-by: RJ Trujillo <eyecantcu@pm.me>
EyeCantCU
force-pushed
the
label-kernel-version
branch
from
c49b93c
to
b2d55f4
Compare
|
Closing in favor of #171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working to acquire the actual kernel version for each image and set that as the
ostree.linuxlabel.