feat: Remove kernel version from kmod name #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antheas
force-pushed
the
remove-version-bundle-akmods
branch
from
b747b50
to
0501278
Compare
p5
previously approved these changes
Oct 19, 2024
bsherman
reviewed
Oct 20, 2024
bsherman
reviewed
Oct 20, 2024
m2Giles
previously approved these changes
Oct 20, 2024
|
You didn't do zfs. |
bsherman
previously requested changes
Oct 20, 2024
bsherman
dismissed
their stale review
Question answered re: where in RPM the version was removed.
This reverts commit 0501278.
antheas
changed the title
bsherman
approved these changes
Oct 20, 2024
m2Giles
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the version name of the kernel from akmods to cleanup changelogs and bundles the akmods used to build the kmods into the resulting image, preventing version drift.
Closes #255