Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #20 from EyeCantCU/rm-wl" #46

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

bsherman
Copy link
Contributor

This reverts commit 697d57c, reversing changes made to 4606c64.

This restores the kmod build for the wl legacy broadcom driver. We can do this because of the PR to main ublue-os/main#278 which only includes specific modules in ublue-os/*-main images.

By restoring this build, downstream users have the option to include the module if required.

Revert "Merge pull request #20 from EyeCantCU/rm-wl"

This reverts commit 697d57c, reversing
changes made to 4606c64.
@bsherman bsherman added this pull request to the merge queue Jul 24, 2023
Merged via the queue into main with commit 6a02fc7 Jul 24, 2023
@bsherman bsherman deleted the restore-legacy-wl branch July 24, 2023 17:39
@ghost
Copy link

ghost commented Jul 24, 2023

I’m assuming you saw my fork, I appreciate this very much! I was using the testing akmod keys just to get something working so thanks for the proper solution! I’m sure it will work fine but I'll test switching over to this later today. Thanks again

@bsherman
Copy link
Contributor Author

I’m assuming you saw my fork, I appreciate this very much!

I'm sorry, I did not actually see the fork, but I hope it was helpful to you in the interim and that this will work for you going forward.

I think we need an update to our README to be more clear on how users wanting to install specific kmods may do so, but for this one it would be adding the following to your custom image Containerfile:

COPY --from=ghcr.io/ublue-os/akmods:${FEDORA_MAJOR_VERSION} /rpms/ /tmp/rpms
RUN rpm-ostree install /tmp/rpms/kmods/kmod-wl-*.rpm

Note: this does expect rpmfusion repos to be enabled in your image already, which is the default for an image based on ublue-os main/nvidia images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants