feat: add nvidia kmod builds and ublue-os-nvidia-addons #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds nvidia kmod builds with a parameterized script which uses the nvidia major version to build the rpmfusion provided akmod for the respective nvidia version. Also this builds the ublue-os-nvidia-addons which includes container runtime repo and sway environment setting for nvidia. This mostly copies (with minor cleanup) from `ublue-os/nvidia` repo; once merged and building cleanly, the nvidia repo can be modified to build images using the kmods built here.
KyleGospo
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds nvidia kmod builds with a parameterized script which uses the nvidia major version to build the rpmfusion provided akmod for the respective nvidia version.
Also this builds the ublue-os-nvidia-addons which includes container runtime repo and sway environment setting for nvidia.
This mostly copies (with minor cleanup) from
ublue-os/nvidiarepo; once merged and building cleanly, the nvidia repo can be modified to build images using the kmods built here.Only two somewhat significant changes (other than some scripting cleanup) stick out in my mind:
nvidiaimage builds are MUCH faster for when we need to just rebuild to pickup some change for synchronizing withmainimagesublue-os-nvidia-addonsRPM as this made things a bit difficult for consuming it in thenvidiaimage builds. We can still disable those by default in thenvidiaimage builds if desired, and I will likely do so over there just to keep the same end state.