Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update image label with actual kernel version #220

Closed
bsherman opened this issue Mar 29, 2024 · 3 comments · Fixed by #237
Closed

feat: update image label with actual kernel version #220

bsherman opened this issue Mar 29, 2024 · 3 comments · Fixed by #237
Assignees
@EyeCantCU

Comments

@bsherman
Copy link
Contributor

Since we use differing kernels from upstream, we should be properly setting the ostree.linux label on the image to reflect the actual kernel within the image.
@bsherman bsherman mentioned this issue Mar 29, 2024
Merged
@bsherman
Copy link
Contributor Author

I haven't checked yet, but I think we could add this to akmods images as well.

@bsherman bsherman mentioned this issue Mar 31, 2024
Closed
@KyleGospo
Copy link
Member

While we're at it, version is using date right now, which is fine -- but it would be nice if it also included commit or build number so two builds on the same date have different version strings.

@bsherman
Copy link
Contributor Author

While we're at it, version is using date right now, which is fine -- but it would be nice if it also included commit or build number so two builds on the same date have different version strings.

that's fine, but lets make that a distinct issue, probably start in main?

@bsherman bsherman moved this to In Progress in Project Goals Apr 10, 2024
@bsherman bsherman moved this from In Progress to Todo in Project Goals Apr 11, 2024
@bsherman bsherman moved this from Todo to In Progress in Project Goals Apr 13, 2024
@bsherman bsherman mentioned this issue Apr 19, 2024
Merged
bsherman added a commit that referenced this issue Apr 19, 2024
@bsherman
chore(ci): use new image labels for linux and image version (#237)
3109c99 
- simplify nvidia build
- use akmods kernel version for ostree.linux
- use KERNEL_FLAVOR (not HWE) to match akmods
- verifiy both the main source image and the akmods-nvidia images

Fixes: #220
@github-project-automation github-project-automation bot moved this from In Progress to Done in Project Goals Apr 19, 2024
@bsherman bsherman mentioned this issue Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EyeCantCU EyeCantCU

Labels
None yet
Projects
Project Goals
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): use new image labels for linux and image version ublue-os/hwe
3 participants
@bsherman @KyleGospo @EyeCantCU