Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump driver version from 545 to 550 #196

Merged
merged 3 commits into from
Mar 1, 2024
Merged

chore: bump driver version from 545 to 550 #196

merged 3 commits into from
Mar 1, 2024

Conversation

dylanmtaylor
Copy link
Contributor

No description provided.

@dylanmtaylor dylanmtaylor changed the title Bump driver version from 545 to 550 chore: bump driver version from 545 to 550 Feb 16, 2024
@dylanmtaylor
Copy link
Contributor Author

The checks are failing even though the driver seems to exist in rpmfusion. I think the issue is that they have it published for "fedora 40" but haven't pushed 550 to the other releases yet. https://pkgs.org/download/akmod-nvidia. We can probably merge this once that hits 39/38.

Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a request for changes simply to block merge until we have upstream akmods building cleanly with this.

Also a note: rpmfusion usually removes the previous "current" very quickly after publishing the new one. So in reality, we'll probably need to replace 545 with 550, rather than only add 550.

@dylanmtaylor
Copy link
Contributor Author

Adding a request for changes simply to block merge until we have upstream akmods building cleanly with this.

Also a note: rpmfusion usually removes the previous "current" very quickly after publishing the new one. So in reality, we'll probably need to replace 545 with 550, rather than only add 550.

This makes sense. I wouldn't merge something that doesn't build. I'll update it to swap 545 -> 550 when it's published.

@bsherman
Copy link
Contributor

I wouldn't merge something that doesn't build.

I didn't mean to imply you would, but crazier things have happened in this project. :-)

Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

auto-merge was automatically disabled February 25, 2024 19:33

Head branch was pushed to by a user without write access

@bsherman bsherman enabled auto-merge March 1, 2024 22:46
@bsherman bsherman added this pull request to the merge queue Mar 1, 2024
Merged via the queue into ublue-os:main with commit 468683f Mar 1, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants