chore: proposal refactor

[p5]

Just an idea of a refactor to make it slightly easier to work in this repo.

TODO:

• Figure out if I broke the alternatives hacks
• Ensure package script still works after small refactor
• Confirm removal of cosign binary is okay
• Can we just always run initramfs regeneration, no matter the kernel?

[bsherman]

why does is this bind mount changed to rw=true?

[p5]

This was added because I got annoyed with permissions on the scripts directory. The Containerfile now chmod +xs all scripts in the directory, which required write access. It can be removed if we wish to proceed with this.

[bsherman]

I like the bind being read-only, seems a bit odd to mutate the scripts on the fly.

Alternatives are:

1. chmod +x the scripts locally and commit the change
2. bash /ctx/build_files/scriptname.sh at runtime instead of /ctx/build_files/scriptname.sh

[xynydev]

Option 2 seems solid, if all the scripts are standardized as bash scripts.

[m2Giles]

I find it unlikely for us to move off of bash any time soon so option 2 would be reasonable for me.

[bsherman]

I don't really understand why the permissions are problematic in the first place. They are stored in git repo.

Only potential problem is someone committing in windows (not WSL).

[m2Giles]

If you aren't reliant on exit for control flow, you could source the scripts instead

…

On Tue, Nov 5, 2024, 6:53 PM Robert Sturla ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Containerfile <#670 (comment)>: > RUN --mount=type=cache,dst=/var/cache/rpm-ostree \ - --mount=type=bind,from=ctx,src=/,dst=/ctx \ + --mount=type=bind,rw=true,from=ctx,src=/,dst=/ctx \ This was added because I got annoyed with permissions on the scripts/ directory. The Containerfile now chmod +xs all scripts in the directory, which required write access. It can be removed if we wish to proceed with this. — Reply to this email directly, view it on GitHub <#670 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQPNFFIQXP76FLSNF2ZCZODZ7FK6PAVCNFSM6AAAAABQ7LUVHKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJXGAYDENJQGI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>