-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
There's a mismatch (
Either tell snapcraft that the binary is diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
index a9d9875..b9d38c3 100644
--- a/snap/snapcraft.yaml
+++ b/snap/snapcraft.yaml
@@ -49,7 +49,7 @@ parts:
apps:
yaru-icons-example:
- command: bin/yaru_icons_example
+ command: bin/example
desktop: snap/gui/yaru-icons-example.desktop
extensions: [gnome]
plugs: Or rename the binary to diff --git a/example/linux/CMakeLists.txt b/example/linux/CMakeLists.txt
index a558bc4..9ffa4f2 100644
--- a/example/linux/CMakeLists.txt
+++ b/example/linux/CMakeLists.txt
@@ -1,7 +1,7 @@
cmake_minimum_required(VERSION 3.10)
project(runner LANGUAGES CXX)
-set(BINARY_NAME "example")
+set(BINARY_NAME "yaru_icons_example")
set(APPLICATION_ID "com.example.example")
cmake_policy(SET CMP0063 NEW) |
a4da8f2
to
e38151b
Compare
@jpnurmi I just checked the Btw, I also changed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
$ snapcraft
Launching instance...
...
Version has been set to '0+git.e38151b'
Created snap package yaru-icons-example_0+git.e38151b_amd64.snap
$ snap install yaru-icons-example_0+git.e38151b_amd64.snap --dangerous
yaru-icons-example 0+git.e38151b installed
$ yaru-icons-example
Works :)
Yes, thanks for fixing it! |
Awesome, thanks. I had another question: I looked at the snapcraft doc, and I didn't saw how to do automated uploads. Is it possible? |
On snapcraft.io, you can link a snap to a GitHub repo. :) |
Oh okay, great! |
Snap published! https://snapcraft.io/yaru-icons-example Still only in |
@kenvandine I simply copied that you did here: ubuntu/yaru.dart#367
But I'd like to have your review and your help to publish it.
Fixes #135