Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial updates for base and extension #1

Merged
merged 5 commits into from
Feb 18, 2022

Conversation

hellsworth
Copy link

No description provided.

@hellsworth
Copy link
Author

There's currently a build failure I'm stumped on:

Configuring org.gnome.Dictionary.appdata.xml.in using configuration                   
                                                                                      
../src/data/appdata/meson.build:3:5: ERROR: Function does not take positional arguments.                                                                                     
                                                                                      
A full log can be found at /root/parts/gnome-dictionary/build/meson-logs/meson-log.txt                                                                                       
Failed to build 'gnome-dictionary'.                                                   
                                                                                      
Recommended resolution:                                                               
Check the build logs and ensure the part's configuration and sources are correct.

here is the meson.build file line 5 so maybe we need a newer compiler to allow positional arguments?? @kenvandine thoughts?

@seb128
Copy link
Contributor

seb128 commented Jan 31, 2022

the build error is due to a misuse of meson which was accepted b older versions but turned into an error now, we workaround it in other snaps by setting 'meson-version: 0.58.1' as in https://bazaar.launchpad.net/~desktop-snappers/gnome-calendar/snap/revision/35

details on mesonbuild/meson#9441

Fixes ftbfs issue. See https://t.ly/xZdL for more context.
@hellsworth
Copy link
Author

Thanks @seb128 so much for the guidance!!!

@hellsworth
Copy link
Author

@seb128 when we pin the meson version (I've tried with several different meson versions in local builds, all with the same result), we see many of these errors:

/snap/gnome-3-38-2004-sdk/current/usr/include/stdio.h:456:24: error: redundant redeclaration of ‘vscanf’ [-Werror=redundant-decls]
  456 | extern int __REDIRECT (vscanf, (const char *__restrict __format,
      |

@seb128 what do you think of this? It looks like maybe a gcc version problem but debugging that and building the right custom gcc as part of gnome-dictionary seems like overkill...

@seb128
Copy link
Contributor

seb128 commented Feb 2, 2022

@kenvandine hit similar issue with the sdk snaps build before, that's weird. The meson issue has been fixed in https://gitlab.gnome.org/GNOME/gnome-dictionary/-/commit/cf3f8a67c , could you try to remove the meson version and build from master instead?

@hellsworth
Copy link
Author

As a note, yesterday I tried master but also with the pin'd version of meson at 0.61.0, and hit this same issue.

@hellsworth
Copy link
Author

hellsworth commented Feb 7, 2022

could you try to remove the meson version and build from master instead?

Even with meson not-pin'd, and building gnome-dictionary from upstream's master branch (pushed this change to my branch so you can see exactly what i'm building), still gives the same build failure.

Heather Ellsworth added 2 commits February 15, 2022 15:56
Delete line in meson.build file that would error on redundant
declarations. See ubuntu#1 for more info on the build failure.
@hellsworth hellsworth changed the title [WIP] Initial updates for base and extension Initial updates for base and extension Feb 17, 2022
@kenvandine
Copy link
Member

I suspect the root cause of the redundant declarations issue lies in either the SDK snap or the extension. We should try to figure that out, buts work around it to help get everything to core22.

@kenvandine kenvandine merged commit 725e570 into ubuntu:stable Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants