-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial updates for base and extension #1
Conversation
There's currently a build failure I'm stumped on:
here is the meson.build file line 5 so maybe we need a newer compiler to allow positional arguments?? @kenvandine thoughts? |
a6809dd
to
66fa632
Compare
the build error is due to a misuse of meson which was accepted b older versions but turned into an error now, we workaround it in other snaps by setting 'meson-version: 0.58.1' as in https://bazaar.launchpad.net/~desktop-snappers/gnome-calendar/snap/revision/35 details on mesonbuild/meson#9441 |
Fixes ftbfs issue. See https://t.ly/xZdL for more context.
Thanks @seb128 so much for the guidance!!! |
@seb128 when we pin the meson version (I've tried with several different meson versions in local builds, all with the same result), we see many of these errors:
@seb128 what do you think of this? It looks like maybe a gcc version problem but debugging that and building the right custom gcc as part of gnome-dictionary seems like overkill... |
@kenvandine hit similar issue with the sdk snaps build before, that's weird. The meson issue has been fixed in https://gitlab.gnome.org/GNOME/gnome-dictionary/-/commit/cf3f8a67c , could you try to remove the meson version and build from master instead? |
As a note, yesterday I tried master but also with the pin'd version of meson at 0.61.0, and hit this same issue. |
Even with meson not-pin'd, and building gnome-dictionary from upstream's master branch (pushed this change to my branch so you can see exactly what i'm building), still gives the same build failure. |
Delete line in meson.build file that would error on redundant declarations. See ubuntu#1 for more info on the build failure.
I suspect the root cause of the redundant declarations issue lies in either the SDK snap or the extension. We should try to figure that out, buts work around it to help get everything to core22. |
No description provided.