Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YaruCarouselController.startTimer() #379

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Fix YaruCarouselController.startTimer() #379

merged 1 commit into from
Nov 11, 2022

Commits on Nov 11, 2022

  1. Fix YaruCarouselController.startTimer()

    Don't schedule a timer when no longer attached. This fixes the following
    exception that occurred while randomly browsing the example.
    
    ```
    [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: 'package:flutter/src/widgets/scroll_controller.dart': Failed assertion: line 107 pos 12: '_positions.isNotEmpty': ScrollController not attached to any scroll views.
    package:flutter/…/widgets/scroll_controller.dart:107
    package:flutter/…/widgets/scroll_controller.dart:107
    package:yaru_widgets/…/utilities/yaru_carousel.dart:337
    ```
    jpnurmi committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    b0bb45d View commit details
    Browse the repository at this point in the history