-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: migrate yaru.dart and yaru_icons.dart into yaru_widgets #836
Conversation
Now that yaru_colors.dart has the Ubuntu Butterfly Pink, we can have the variant in yaru.dart
Example: improve variant selector and show all
* Add source code </> icon Fixes #78 * Better icon
* Text inputs: change cursor color to onSurface * Change inputs icon color to onSurface
* Rename toggle-button folder into toogle - Checkbox-button -> checkbox - Radio-button -> radio - Switch-button -> switch * Rename arrow icons - Arrow-*-simple -> arrow - Arrow -> arrow-filled * Rename audio -> music_note * Rename addon -> puzzle_piece * Rename arrow -> arrow-outlined * Optimize bettery naming - Battery-10 -> battery-full - Divide by 10 battery level - Remove level prefix * Simplify weather icon names Add new showers icon * Symlink online-accounts to could * Rename edit-*icons * Add folder-new icon * Improve media and text icon names * Optimize object icon names * Optimize object icon names * Sync printer-network with folder-network * Radio -> radiobox * Optimize speaker icon names * Revert example.dart * Optimize fullscreen icon names * Better computer-legacy icon * Simplify all other icon names * Add screen icon * Improve a few last icon names * Remove new icons (for next PR) * Fix battery empty name * Build font * Update example
* Add binding enum of freedesktop compliant icon names Fixes #104 * Add shortcut to all icons
* YaruTheme widget: build empty during accent color initialiation Fixes: #231 * Use mocked GSettings in all widget tests
Bildschirmaufnahme_2024-02-23_um_14.14.07.movThe goldens pass locally after clean/upgrade and regeneration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can improve and simplify some files placements:
colors.dart
could be moved to thefoundation/
folder ;icons_foundation/
could be merged withfoundation
;text/font/
should be moved toassets/
, andtext/text_theme.dart
tothemes/
;icons_widgets/
towidgets
;- and I'm not sure, but
theme_widgets/inherited_theme.dart
can maybe be moved towidgets/
(orthemes/
) ?
Except that, this looks great. I didn't noticed any problem with icons :D
I kept the sub structure for this PR to make a first atempt where everything works. Maybe I could do this in a second PR? then I change from Fix to Ref in the PR desc |
Ofc, sounds good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
BREAKING CHANGE
This migrates yaru.dart and yaru_icons.dart into this repository, but all commits are kept 🤞
To merge this we need to check very precicly if everything is correctly merged
TODO
Ref #835