Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(example): improve wording, placement and info #884

Merged
merged 1 commit into from
Mar 10, 2024
Merged

chore(example): improve wording, placement and info #884

merged 1 commit into from
Mar 10, 2024

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Mar 10, 2024 •
edited
Loading

Improved the placement of pages, wording, info and naming for people not involved into yaru yet:

  • material components as the first page, as this page has the texttheme and buttons, which is important to see right away
  • improved page wording to make it clear that those are pure material components but with Yaru theming
  • improved text on/for components where it is not clear what type they are
  • added the nice new infoboxes for coponents that have a YaruXXX replacement
Bildschirmfoto 2024-03-10 um 09 26 01 Bildschirmfoto 2024-03-10 um 09 26 30 Bildschirmfoto 2024-03-10 um 09 26 45 Bildschirmfoto 2024-03-10 um 09 26 57

Jupi007
Jupi007 approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Very nice!

@Feichtmeier Feichtmeier merged commit 5a4dec7 into main Mar 10, 2024
8 checks passed
@Feichtmeier Feichtmeier deleted the improve_example branch March 10, 2024 09:16
@github-actions github-actions bot mentioned this pull request Mar 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Feichtmeier @Jupi007