PXP-10229 Client auth mapping #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avantol13
reviewed
Oct 14, 2022
arborist/server.go
Outdated
| username = usernameQS[0] | ||
| } else if authHeader := r.Header.Get("Authorization"); authHeader != "" { | ||
| // Fall back to JWT for username. Added for Arborist UI integration... | ||
| if authHeader := r.Header.Get("Authorization"); authHeader != "" { | ||
| server.logger.Info("No username in query args; falling back to jwt...") |
There was a problem hiding this comment.
we should probably remove this log or update the language
There was a problem hiding this comment.
see other logs below too, ensure wording doesn't imply "falling back" to jwt
Avantol13
approved these changes
Oct 17, 2022
This was referenced Oct 18, 2022
Merged
Merged
Closed
Updating Env chicagoland.pandemicresponsecommons.org - 2022.10 1666369665
uc-cdis/cdis-manifest#5284
Merged
This was referenced Jan 27, 2023
This was referenced Feb 3, 2023
This was referenced Mar 30, 2023
This was referenced Dec 12, 2023
Merged
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-10229
New Features
POST /auth/mappingendpoint now supports aclientIDparameter to get the auth mapping for a client. It accepts either ausernameparameter or aclientIDparameter (not both).Breaking Changes
GET /auth/mappingendpoint does not acceptusernameas a query parameter anymore. It only supports parsing the username from the provided JWT. To specify a username, use thePOST /auth/mappingendpoint.Bug Fixes
Improvements
Dependency updates
Deployment changes