[HP-1539] Add AWS functionality to cirrus #96
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
gen3cirrus/aws/services.py
Outdated
| import backoff | ||
| import boto3 | ||
| from botocore.exceptions import ClientError | ||
| from gen3cirrus.config import config |
There was a problem hiding this comment.
I'd prefer if we break up the imports by newlines for 3 sections:
- built in libs
- external deps
- internal imports
gen3cirrus/aws/services.py
Outdated
| Generic Amazon servicing using Boto3 | ||
| """ | ||
|
|
||
| def __init__(self, client): |
There was a problem hiding this comment.
maybe just so it's super clear we should call this boto3_client?
gen3cirrus/aws/services.py
Outdated
| Generic Amazon servicing using Boto3 | ||
| """ | ||
|
|
||
| def __init__(self, client): |
| Test that we can get a presigned url from a bucket | ||
| """ | ||
|
|
||
| s3 = boto3.client("s3", aws_access_key_id="", aws_secret_access_key="") |
There was a problem hiding this comment.
I'm not seeing where this is mocked, so I'm actually not sure how this is passing
There was a problem hiding this comment.
I'm not sure it need mocks 🤔 the generate_presigned_url() in boto3 is a local operation
| assert url != None | ||
|
|
||
|
|
||
| def test_aws_get_presigned_url_requester_pays(): |
There was a problem hiding this comment.
we need more tests for the negative cases where boto throws an error
|
@Avantol13 what do you think about https://github.com/uc-cdis/fence/pull/1173/files#r1727515677 ? |
New Features