Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PXP-9516): Add metadata-delete-expired-objects job #1941

Merged
merged 8 commits into from
Jan 11, 2023
Merged

(PXP-9516): Add metadata-delete-expired-objects job #1941

merged 8 commits into from
Jan 11, 2023

Conversation

nss10
Copy link
Contributor

@nss10 nss10 commented May 24, 2022 •
edited by jira bot
Loading

Jira Ticket: PXP-9516

New Features

  • Add the metadata-delete-expired-objects job, which removes expired objects from indexd, fence and Metadata Service. Set it up by running the gen3 kube-setup-metadata-delete-expired-objects-cronjob command

Deployment changes

  • To set up the metadata-delete-expired-objects job, run the gen3 kube-setup-metadata-delete-expired-objects-cronjob command. Note that the metadata-delete-expired-objects-job client must be granted access to (resource=/mds_gateway, method=access, service=mds_gateway) and (resource=/programs, method=delete, service=fence)

@nss10 nss10 requested a review from paulineribeyre May 24, 2022 21:29
@paulineribeyre paulineribeyre changed the title (PXP-9516): Create and run new k8s cronjob remove_tmp_indexd_records (PXP-9516): Add delete-expired-objects k8s cronjob May 25, 2022
@paulineribeyre paulineribeyre marked this pull request as draft May 25, 2022 21:33
paulineribeyre
paulineribeyre reviewed May 25, 2022
View reviewed changes
Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Job code at uc-cdis/sower-jobs#39

kube/services/jobs/delete-expired-objects-cronjob.yaml Outdated Show resolved Hide resolved
kube/services/jobs/delete-expired-objects-job.yaml Outdated Show resolved Hide resolved
@nss10 nss10 requested a review from paulineribeyre May 31, 2022 17:35
paulineribeyre
paulineribeyre previously approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nss10 nss10 marked this pull request as ready for review June 1, 2022 17:25
@paulineribeyre
Copy link
Contributor

This is now unblocked and will be updated when PXP-9985 can be prioritized

@paulineribeyre paulineribeyre marked this pull request as draft October 3, 2022 22:16
@paulineribeyre paulineribeyre mentioned this pull request Dec 7, 2022
Merged
@paulineribeyre paulineribeyre changed the title (PXP-9516): Add delete-expired-objects k8s cronjob (PXP-9516): Add metadata-delete-expired-objects job Jan 10, 2023
@paulineribeyre paulineribeyre marked this pull request as ready for review January 11, 2023 19:13
@paulineribeyre paulineribeyre merged commit 9c12b18 into master Jan 11, 2023
@paulineribeyre paulineribeyre deleted the feat/delete_expired_objects branch January 11, 2023 20:10
This was referenced Jan 20, 2023
Merged
Closed
This was referenced Jan 25, 2023
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 2, 2023
Merged
Closed
This was referenced Mar 30, 2023
Merged
Merged
@github-actions github-actions bot mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

Assignees
No one assigned
Labels
skip-gen3-helper-tests test-apis-userTokenTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nss10 @paulineribeyre @jawadqur