Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add new config for integrating teamproject and arborist check #2397

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Feat: add new config for integrating teamproject and arborist check #2397

merged 6 commits into from
Oct 27, 2023

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Oct 26, 2023 •
edited by jira bot
Loading

Jira Ticket: VADC-775

New Features

  • Add new config for integrating teamproject and arborist check: these properties are needed for enabling "teamproject" authorization mode in WebAPI and telling WebAPI where the Arborist endpoint is living for actually getting authorization information.

Dependency updates

  • The WebAPI deployment now depends not only on Fence, but also needs a direct link to Arborist

Deployment changes

  • This assumes Arborist and WebAPI are on the same internal network

@pieterlukasse
feat: add new config for integrating teamproject and arborist check
600e125 
...these properties are needed for enabling "teamproject" authorization mode
in WebAPI and telling WebAPI where the Arborist endpoint is living for
actually getting authorization information.
m0nhawk
m0nhawk previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@m0nhawk m0nhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Let's try this.

@pieterlukasse
revert default value for ARBORIST_URL
c0fc031 
...the service will already default to arborist-service url if not defined
m0nhawk
m0nhawk approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@m0nhawk m0nhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AidanHilt AidanHilt merged commit 3ff37b9 into master Oct 27, 2023
6 of 7 checks passed
@AidanHilt AidanHilt deleted the feat/new_config_for_integrating_teamproject_and_arborist_check branch October 27, 2023 19:05
This was referenced Oct 27, 2023
Closed
Merged
This was referenced Nov 29, 2023
Open
Merged
Merged
This was referenced Dec 8, 2023
Merged
Merged
Closed
Merged
Closed
Merged
Closed
Merged
Merged
Closed
Closed
@github-actions github-actions bot mentioned this pull request Dec 20, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jan 4, 2024
Merged
This was referenced Jan 16, 2024
Merged
Closed
This was referenced Feb 2, 2024
Closed
Merged
This was referenced Feb 16, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0nhawk m0nhawk m0nhawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pieterlukasse @m0nhawk @AidanHilt