Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PXP-6570): refactor/dictionaryBtnColor: change dictionary btn to use defined global colors #822

Merged
merged 1 commit into from
Mar 11, 2021
Merged

(PXP-6570): refactor/dictionaryBtnColor: change dictionary btn to use defined global colors #822

merged 1 commit into from
Mar 11, 2021

Conversation

ocshawn
Copy link
Contributor

@ocshawn ocshawn commented Mar 10, 2021 •
edited by mfshao
Loading

Jira Ticket: PXP-6570

Improvements

  • make data dictionary button color will honor the secondary button color

Deployment Changes

  • envs with customized color schemes no longer need to overwrite dictionary button color in their gitops.css

@ocshawn
Copy link
Contributor Author

ocshawn commented Mar 10, 2021

note currently tested in https://qa-covid19.planx-pla.net/ need to test in more environments

@ocshawn
Copy link
Contributor Author

ocshawn commented Mar 11, 2021

also tested in:
https://accessclinicaldata.niaid.nih.gov/DD
https://acct.bionimbus.org/DD
https://aids.niaiddata.org/DD
https://chicagoland.pandemicresponsecommons.org/DD
https://data.bloodpac.org/DD
https://data.braincommons.org/DD
https://data.kidsfirstdrc.org/DD
https://data.midrc.org/DD
https://dataprep.braincommons.org/DD
https://flu.niaiddata.org/DD
https://gen3.biodatacatalyst.nhlbi.nih.gov/DD

@ocshawn ocshawn merged commit 8bde647 into master Mar 11, 2021
@ocshawn ocshawn deleted the refactor/dictionaryBtnColor branch March 11, 2021 16:45
This was referenced May 6, 2021
Merged
Merged
This was referenced Jun 10, 2021
Closed
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Jun 21, 2021
Merged
@paulineribeyre paulineribeyre mentioned this pull request Jul 14, 2021
Merged
This was referenced Aug 20, 2021
Closed
Closed
This was referenced Aug 31, 2021
Merged
Merged
Merged
Closed
This was referenced Sep 13, 2021
Merged
Merged
Merged
This was referenced Sep 20, 2021
Merged
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Sep 28, 2021
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Oct 13, 2021
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Oct 20, 2021
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Nov 17, 2021
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Dec 10, 2021
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Jan 11, 2022
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Jan 20, 2022
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Feb 3, 2022
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Mar 2, 2022
Merged
This was referenced Mar 18, 2022
Merged
Merged
This was referenced Apr 1, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Oct 21, 2022
Closed
This was referenced Dec 19, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfshao mfshao mfshao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocshawn @mfshao