feat(backoff): add backoff to Google Group API calls #1081
Conversation
Pull Request Test Coverage Report for Build 13464
💛 - Coveralls |
| def _add_member_to_google_group(gcm, add_member_to_group, group): | ||
| gcm.add_member_to_group(member_email, group) |
There was a problem hiding this comment.
should we update the add_member_to_group calls to _add_member_to_google_group in bulk_update_google_groups()?
There was a problem hiding this comment.
same for the other 2 functions
There was a problem hiding this comment.
whoops, yes. Just pushed a commit to fix
There was a problem hiding this comment.
not sure if you meant to add backoff to all the calls or just the bulk_update_google_groups process?
get_group_members is called in verify_bucket_access_group
add_member_to_group in add_user_service_account_to_google
remove_member_from_group in a bunch of functions
There was a problem hiding this comment.
just the bulk updates, the others should happen dynamically when a user requests access to data and/or during validation job where the number of calls is much less. This is just to alleviate the quota exceeded issues during usersync
Jira Ticket: PXP-xxxx
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes