Remove Foreign Key Constraints for Service Account

[BinamB]

Link to JIRA ticket if there is one:
Pre-alembic era created a foreign key clent_id(from the client table) on the google_service_account table. This foreign key was then removed from the schema but any commons created before the constraint was removed still held the foreign key. The previous alembic migration tuncates the client table but this fails if the foreign key constraint still persists therefore failing the migration. This migration checks for the existence of the foreign key constraint and removes it if it exists. There is no downgrade path for this since not having the foreign key constraint is the correct schema throughout all versions. This migration is specifically for commons that were created before the foreign key constraint was removed.

New Features

Breaking Changes

Bug Fixes

• Create new migration to remove foreign key constraint if it exists on google_service_account table

Improvements

Dependency updates

Deployment changes

• Requires database migration

[coveralls]

Pull Request Test Coverage Report for Build 10322529192

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 75.278%

---

Totals
Change from base Build 10290555822:	0.0%
Covered Lines:	7792
Relevant Lines:	10351

---

💛 - Coveralls

[k-burt-uch]

Do we have a way to test that the full alembic migration succeeds? IIRC the migration fails here:
https://github.com/uc-cdis/fence/blob/master/migrations/versions/9b3a5a7145d7_authlib_update_1_2_1.py

Because of this FK constraint. But this only tests if the migration to remove the FK constraint succeeds, not that the collection of migration scripts succeeds.

I think a full migration check is beyond the scope of what you're doing here, but it might be best to move the removal of the FK to the previous migration https://github.com/uc-cdis/fence/blob/master/migrations/versions/9b3a5a7145d7_authlib_update_1_2_1.py here instead of adding a new migration.

[k-burt-uch]

Can't we update this migration
https://github.com/uc-cdis/fence/blob/master/migrations/versions/9b3a5a7145d7_authlib_update_1_2_1.py

To do this instead of making a new migration?

[Avantol13]

yeah, this won't work. We can't have a new migration b/c the previous one fails. We must update the previous one

[Avantol13]

yeah, this won't work. We can't have a new migration b/c the previous one fails. We must update the previous one