-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws requester pays #1173
Merged
Merged
aws requester pays #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10581704084Details
💛 - Coveralls |
…o feat/aws-requesterpays
Avantol13
requested changes
Aug 14, 2024
mfshao
reviewed
Aug 14, 2024
mfshao
reviewed
Aug 15, 2024
This was referenced Oct 7, 2024
Merged
This was referenced Oct 15, 2024
Merged
Merged
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing from using https://github.com/uc-cdis/cdis-python-utils/ for generating S3 presigned urls to the new presigned url generator https://github.com/uc-cdis/cirrus/
The main reason this change was made was to enable the requester pays bucket presigned url generation.
To enable requester pays buckets a boolean flag must be added to the bucket configuration. example below
New Features
Improvements
boto3
for AWS S3 presigned url generationgen3cirrus
Deployment changes
/fence/config-default.yaml
for detailsDependency updates
gen3cirrus
to 3.1.0boto3
to 1.35.6