Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws requester pays #1173

Merged
merged 40 commits into from
Aug 27, 2024
Merged

aws requester pays #1173

merged 40 commits into from
Aug 27, 2024

Conversation

MichaelLukowski
Copy link
Member

@MichaelLukowski MichaelLukowski commented Aug 8, 2024

Changing from using https://github.com/uc-cdis/cdis-python-utils/ for generating S3 presigned urls to the new presigned url generator https://github.com/uc-cdis/cirrus/

The main reason this change was made was to enable the requester pays bucket presigned url generation.

To enable requester pays buckets a boolean flag must be added to the bucket configuration. example below

requestor-pays-test-public:
    cred: cdistest
    requester_pays: true
    region: 'us-east-1'

New Features

  • Add support for generating presigned urls for requester pay enabled AWS S3 buckets

Improvements

  • Use boto3 for AWS S3 presigned url generation
  • Move AWS S3 presigned url generation related functionality into gen3cirrus

Deployment changes

  • New configuration has been added into Fence config for requester pay enabled AWS S3 buckets, please refer to /fence/config-default.yaml for details

Dependency updates

  • gen3cirrus to 3.1.0
  • boto3 to 1.35.6

@coveralls
Copy link

coveralls commented Aug 13, 2024

Pull Request Test Coverage Report for Build 10581704084

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 56 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 75.333%

Files with Coverage Reduction New Missed Lines %
blueprints/data/multipart_upload.py 23 26.92%
blueprints/data/indexd.py 33 94.48%
Totals Coverage Status
Change from base Build 10290555822: 0.06%
Covered Lines: 7803
Relevant Lines: 10358

💛 - Coveralls

fence/blueprints/data/indexd.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests/migrations/test_9b3a5a7145d7.py Outdated Show resolved Hide resolved
fence/blueprints/data/indexd.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants