Fix/presigned url addressing style #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10607427461Details
💛 - Coveralls |
PlanXCyborg
added
test-apis-centralizedAuth
test-apis-dbgapTest
and removed
@requires-fence
labels
mfshao
added
@requires-fence
and removed
test-apis-dbgapTest
test-apis-centralizedAuth
labels
PlanXCyborg
added
test-apis-centralizedAuth
test-apis-dbgapTest
and removed
@requires-fence
labels
| @@ -148,7 +148,7 @@ def generate_presigned_url_for_uploading_part( | |||
| aws_secret_access_key=credentials["aws_secret_access_key"], | |||
| aws_session_token=credentials.get("aws_session_token", None), | |||
| region_name=region, | |||
| config=Config(s3={"addressing_style": "path"}, signature_version="s3v4"), | |||
| config=Config(signature_version="s3v4"), | |||
There was a problem hiding this comment.
no need to add endpoint_url here?
There was a problem hiding this comment.
I'm not sure. It appears to be not there before, and the clever safe tests in CI are for download only.
But I can try to add it later 🤔
mfshao
added
@requires-fence
and removed
test-apis-dbgapTest
test-apis-centralizedAuth
labels
PlanXCyborg
added
test-apis-centralizedAuth
test-apis-dbgapTest
and removed
@requires-fence
test-apis-centralizedAuth
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes
autoaddressing style for presigned url generation (attempts to usevirtual, but falls back topathif necessary)endpoint_urlfrom Fence config to boto3 client for presigned url creation