PXP-6406 Feat/ga4gh scope #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 9346
💛 - Coveralls |
vpsx
added
the
test-google-googleDataAccessTest
vpsx
added
test-google-googleDataAccessTest
paulineribeyre
approved these changes
Jul 23, 2020
TECHDEBT.md
Outdated
Comment on lines
4
to
6
| Observed: July 2020 | ||
| Impact: (If this tech debt affected your work somehow, add a +1 here with a date and note) | ||
| +1 Zoe 2020 July 15 This is an example of a +1 |
There was a problem hiding this comment.
markdown displays paragraphs not separated by newlines as a single paragraph
TECHDEBT.md
Outdated
| ##### What the solution might be: | ||
| GA4GH AAI already requires that a 'scope' claim be included in access tokens issued by Passport Brokers: | ||
| https://github.com/ga4gh/data-security/blob/master/AAI/AAIConnectProfile.md#access_token-issued-by-broker | ||
| So as of July 2020 we will put scopes in the 'scope' claim. However, this is in addition to keeping them in the 'aud' claim. Ideally we would only have the scopes in the 'scope' claim. |
This was referenced Aug 31, 2020
This was referenced Sep 11, 2020
Closed
This was referenced Dec 18, 2023
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also introduces a techdebt.md
New Features
Deployment changes