Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blank): uploader is no longer technically required since arborist… #277

Merged
merged 1 commit into from
May 26, 2020

Conversation

Avantol13
Copy link
Contributor

… is used for authz

New Features

Breaking Changes

  • indexd blank record endpoints no longer require uploader field

Bug Fixes

Improvements

Dependency updates

Deployment changes

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference

The flow now uses arborist to determine if you can create blank records and I think we should allow people to not specify an uploader since it's technically an optional field on the record.
The frontend still relies on the uploader field being there for the current data upload flow / mapping, and for commons that still use acl instead of authz, we still need uploader to know if the user can update the blank record. The Gen3 client for data upload flow still uses only the acl and does update the uploader.
In other words, I think this is backwards compatible, you can either do data upload the old way, or the new way, you just no longer get an error if you try the old way and don't add an uploader for some reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants