Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing requests to 2.23.2 #58

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Changing requests to 2.23.2 #58

merged 1 commit into from
Sep 19, 2024

Conversation

nss10
Copy link
Contributor

@nss10 nss10 commented Sep 18, 2024

Link to JIRA ticket if there is one: PPS-1582

Dependency updates

  • Changing requests to 2.32.2

Copy link

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_manifest\_service.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

Copy link
Contributor

@george42-ctds george42-ctds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -15,7 +15,7 @@ Flask = "^2.3.2"
authutils = "<7"
boto3 = "^1.17.48"
cryptography = ">=42.0.5"
requests = "^2.32.0"
requests = "^2.32.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"^2.32.0" already includes "^2.32.2", and relocking effectively upgraded requests to "2.32.3", so the PR description/title aren't really accurate - and if you check the lock file diff, you'll see that you upgraded many other deps too by relocking. So just "upgrading dependencies" would be fine

@nss10 nss10 merged commit f5498d7 into master Sep 19, 2024
7 checks passed
@nss10 nss10 deleted the chore/pip/requests-2.32.2 branch September 19, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants