Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datasets): add datasets endpoint #111

Merged
merged 1 commit into from
Feb 22, 2019
Merged

feat(datasets): add datasets endpoint #111

merged 1 commit into from
Feb 22, 2019

Conversation

philloooo
Copy link
Contributor

@philloooo philloooo commented Feb 20, 2019 •
edited
Loading

This implements the datasets endpoint that allows anonymous request(if configured) for tiered access feature.
ticket: https://ctds-planx.atlassian.net/browse/PXP-2463
deliverable: https://ctds-planx.atlassian.net/wiki/spaces/PLA/pages/29851651/Tiered+Access
cloud-automation pr: uc-cdis/cloud-automation#699

New Features

  • Add /datasets endpoint to return summary counts for project and allow it to be configured to be public endpoint

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

  • a new environment variable PUBLIC_DATASETS will be required to set for anonymous access to datasets endpoint

@PlanXCyborg
Copy link

Jenkins Build 2 : time taken 1 min 38 sec
Check the https://jenkins.planx-pla.net/job/perf-peregrine/job/PR-111/2/display/redirect

@philloooo philloooo force-pushed the feat/datasetsapi branch 2 times, most recently from 9621c0e to 2a436a3 Compare February 21, 2019 01:35
@PlanXCyborg
Copy link

Jenkins Build 3 : time taken 4 min 45 sec
Check the https://jenkins.planx-pla.net/job/perf-peregrine/job/PR-111/3/display/redirect

@PlanXCyborg
Copy link

Jenkins Build 4 : time taken 19 min
Check the https://jenkins.planx-pla.net/job/perf-peregrine/job/PR-111/4/display/redirect

paulineribeyre
paulineribeyre reviewed Feb 21, 2019
View reviewed changes
Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis is not running your tests! it's not running the transaction_logs tests either https://github.com/uc-cdis/peregrine/blob/master/.travis.yml#L38
also https://github.com/uc-cdis/peregrine/blob/master/run_tests.sh#L14

openapis/swagger.yaml Outdated
parameters:
- in: query
name: nodes
description: quoma delimited nodes to get counts for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo comma

openapis/swagger.yaml Outdated
application/json:
schema:
type: object
example: {project__A: {case: 0, aliquot: 1}, project_B: {case:2, aliquot: 3}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix case:2 -> case: 2 (swagger is displaying "case:2": null)

peregrine/blueprints/datasets.py Show resolved Hide resolved
peregrine/blueprints/datasets.py Outdated
import os
import re

import peregrine.utils
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codacy is complaining about this not being used

@philloooo philloooo force-pushed the feat/datasetsapi branch 2 times, most recently from 0015981 to e161fb0 Compare February 22, 2019 22:46
@PlanXCyborg
Copy link

Jenkins Build 6 : time taken 1 min 21 sec
Check the https://jenkins.planx-pla.net/job/perf-peregrine/job/PR-111/6/display/redirect

@PlanXCyborg
Copy link

Jenkins Build 7 : time taken 1 min 44 sec
Check the https://jenkins.planx-pla.net/job/perf-peregrine/job/PR-111/7/display/redirect

@PlanXCyborg
Copy link

Jenkins Build 8 : time taken 1 min 55 sec
Check the https://jenkins.planx-pla.net/job/perf-peregrine/job/PR-111/8/display/redirect

@PlanXCyborg
Copy link

Jenkins Build 9 : time taken 1 min 18 sec
Check the https://jenkins.planx-pla.net/job/perf-peregrine/job/PR-111/9/display/redirect

@philloooo philloooo merged commit 47a23a8 into master Feb 22, 2019
@philloooo philloooo deleted the feat/datasetsapi branch February 22, 2019 23:09
This was referenced Mar 31, 2020
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philloooo @PlanXCyborg @paulineribeyre