Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXP-8123 Fix various TSV arrays bugs #346

Merged
merged 3 commits into from
May 4, 2021
Merged

PXP-8123 Fix various TSV arrays bugs #346

merged 3 commits into from
May 4, 2021

Conversation

paulineribeyre
Copy link
Contributor

Jira Ticket: PXP-8123

goes with uc-cdis/gen3datamodel#33

  • bug when submitting array items as TSV: 1,2,3 is parsed as ['1', '2', '3'] and we return '1' is not of type 'number'

  • bug when exporting array items to TSV:

  File "/sheepdog/sheepdog/utils/transforms/graph_to_doc.py", line 162, in list_to_comma_string
    val = ",".join(val)
TypeError: sequence item 0: expected str instance, int found
  • bug when reporting array items errors to users:
  File "/sheepdog/sheepdog/transactions/upload/transaction.py", line 52, in record_errors
    keys = [".".join(error.path)] if error.path else []
TypeError: sequence item 1: expected str instance, int found

Bug Fixes

  • Fix bug when submitting array items as TSV
  • Fix bug when exporting array items to TSV
  • Fix bug when reporting array items errors to users

Improvements

  • Add logging to facilitate debugging validation issues

Dependency updates

  • gdcdatamodel to 3.0.3

@PlanXCyborg
Copy link

PlanXCyborg commented May 3, 2021

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@paulineribeyre paulineribeyre merged commit f249745 into master May 4, 2021
@paulineribeyre paulineribeyre deleted the fix/array branch May 4, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants