-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/py3 #119
Chore/py3 #119
Conversation
@@ -123,10 +123,22 @@ def update_level(self): | |||
new_assigned = set([]) | |||
for collector in just_assigned: | |||
for child in collector.children: | |||
if len(child.children) == 0 or child in assigned_levels: | |||
# TODO: PXP-5067 investigate int-string comparison in node lvls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand your comment here. Why do we need to change the logic here? what is the bug?
@thanh-nguyen-dang, in response to your comments here and elsewhere, here is how you can reproduce the problem at hand:
As I said in the ticket, perhaps this is deliberate, but it is pretty idiosyncratic, and at any rate python 3 won't allow it. |
d0d9ebd
to
9d9692d
Compare
d2e1e14
to
a1902e9
Compare
a1902e9
to
31c2f97
Compare
Update to python 3 yayayayay!!!
Regarding node level bug (see bug fixes section), see PXP-5067
Breaking Changes
Bug Fixes
Improvements
Dependency updates