Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

Run RemoveValidIf pass for updated CIRCT #125

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Conversation

abejgonzalez
Copy link
Contributor

Adds an extra flag that allows the compiler to run extra LowFirrtl passes needed for CIRCT to pass (i.e. run the RemoveValidIf pass).

@abejgonzalez
Copy link
Contributor Author

abejgonzalez commented Feb 6, 2023

Another way to do this is to add a RunFirrtlTransformAnnotation to the .json that we emit in CY that specifies the xform to run (i.e. the ExtraPassesTransform). That will avoid us having to add an extra compiler flag that is redundant.

IMO this is cleaner

@joonho3020
Copy link
Contributor

I agree that having duplicate compile flags isn't clean. Are we only performing the ExtraPassesTransform when only using the ENABLE_CUSTOM_FIRRTL_PASS flag?

@abejgonzalez
Copy link
Contributor Author

I agree that having duplicate compile flags isn't clean. Are we only performing the ExtraPassesTransform when only using the ENABLE_CUSTOM_FIRRTL_PASS flag?

Correct. We are only running this when dumping out LowFIRRTL because CIRCT no longer supports validif statements (which are emitted in SFC LowFIRRTL)

@joonho3020
Copy link
Contributor

I see. I can try deduplicating this flag later. In the meanwhile, we can also just merge this in.

@abejgonzalez
Copy link
Contributor Author

Let's merge this in when the new-hammer work gets merged in.

@joonho3020
Copy link
Contributor

okey-dokey

@harrisonliew harrisonliew mentioned this pull request Feb 9, 2023
22 tasks
Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this works. Can we merge this for ucb-bar/chipyard#1324?

@harrisonliew harrisonliew merged commit 9760528 into master Feb 10, 2023
@harrisonliew harrisonliew deleted the run-extra-passes branch February 10, 2023 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants