Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing GH-A Improvements #1004

Merged

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Oct 8, 2021

Related issue: #999

Type of change: new feature

Impact: other

Release Notes
Couple new improvements

  • Tries to emulate the "Run from failed" that CircleCI gives to not rerun passing jobs.
  • Small fix to defaults.sh when running a script with multiple arguments
  • Tries to dedup as much as possible things within the workflow
  • Switch to using build server ferry as a GH-A runner (significantly cleans up scripts)
    Couple workarounds
  • No support for if: clause in composite actions. This requires me to build/cache both toolchains at once... in reality this penalty is paid once every so often that the toolchain changes.

@abejgonzalez
Copy link
Contributor Author

Current issue is that hashFiles (needed for retrieving the toolchain) differs on a GH-A container vs on the self-hosted machine.

@abejgonzalez abejgonzalez merged commit 0194355 into dev-use-github-actions-plus-circle-ci Oct 13, 2021
@jerryz123 jerryz123 deleted the dev-gha-improvements branch October 1, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants