Update pull request template (Feedback welcome) #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abejgonzalez
force-pushed
the
pull_request_update
branch
from
6f7eac9
to
a55594b
Compare
abejgonzalez
changed the title
jerryz123
approved these changes
Nov 4, 2021
| **Contributor Checklist**: | ||
| - [ ] Yes, I specified the "Type of Change" | ||
| - [ ] Yes, I specified the "Impact" | ||
| - [ ] Did you set `dev` as the base branch? |
There was a problem hiding this comment.
The first two bullet points here feel unnecessary, given that it will be quite obvious if the "Type of Change" and "Impact" sections are unfilled.
Otherwise fine.
There was a problem hiding this comment.
I just tried making it extremely apparent that they/us need to fill out both sections... but honestly hasn't been an issue in the past. Done.
abejgonzalez
commented
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: other enhancement
Impact: other
Release Notes
Following along with #1029, I figured we could update the PR template a bit more. Any feedback on anything that we want mentioned a PR before merging it? I added a checkbox on the
devbranch being needed... but I feel like people might get confused with the "Impact" section?