Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document simulator-timeout settings #1094

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

tymcauley
Copy link
Contributor

@tymcauley tymcauley commented Jan 20, 2022

Related issue: N/A

Type of change: new feature

Impact: other

Release Notes

Document simulator-timeout settings.

@jerryz123
Copy link
Contributor

Hmm, I have been using timeout_cycles without issue, without needing this change....

@tymcauley
Copy link
Contributor Author

Ah, interesting, let me give that a shot.

@tymcauley
Copy link
Contributor Author

Yup, you're right, setting those variables on the command-line works for me. Should we still add them to the help text, so they're more discoverable?

@jerryz123
Copy link
Contributor

Yeah, adding them to the help text is a good idea.

@tymcauley
Copy link
Contributor Author

Sounds good, I'll update this branch to only contain the help text info

@tymcauley tymcauley changed the title Let users override simulator timeout settings WIP: Let users override simulator timeout settings Jan 20, 2022
@tymcauley tymcauley changed the title WIP: Let users override simulator timeout settings Add documentation on simulator-timeout settings Jan 21, 2022
@tymcauley tymcauley changed the title Add documentation on simulator-timeout settings Document simulator-timeout settings Jan 21, 2022
@tymcauley
Copy link
Contributor Author

@jerryz123 I've cleaned this up, let me know what you think.

@jerryz123 jerryz123 self-requested a review January 21, 2022 17:46
@jerryz123 jerryz123 merged commit 9adb103 into ucb-bar:dev Jan 21, 2022
@tymcauley tymcauley deleted the override-timeout branch January 21, 2022 17:47
@tymcauley
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants