Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firesim: Add a config with no mem port #1172

Merged
merged 1 commit into from
Jun 15, 2022
Merged

firesim: Add a config with no mem port #1172

merged 1 commit into from
Jun 15, 2022

Conversation

davidbiancolin
Copy link
Contributor

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 self-requested a review June 9, 2022 15:29
@michael-etzkorn
Copy link
Contributor

Not sure if the ordering comes into play since I haven't looked at WithFireSimConfigTweaks but I think some users would like a RocketNoMemPortConfig with no FireSim so this could be two separate configs.

Something like:

 class NoMemPortRocketConfig extends Config(
  new freechips.rocketchip.subsystem.WithNoMemPort ++
  new testchipip.WithBackingScratchpad ++
  new chipyard.RocketConfig)
class FireSimNoMemPortConfig extends Config(
  new WithDefaultFireSimBridges ++
  new WithFireSimConfigTweaks ++
  new chipyard.NoMemPortRocketConfig)

@davidbiancolin
Copy link
Contributor Author

@michael-etzkorn That would be great. If you wanted to PR that I'd highly appreciate it as i'm quite short on time atm.

@michael-etzkorn
Copy link
Contributor

michael-etzkorn commented Jun 11, 2022

@michael-etzkorn That would be great. If you wanted to PR that I'd highly appreciate it as i'm quite short on time atm.

Probably best to merge this now and I'll make a note to make a PR to break it up. That PR will probably happen whenever I circle back to my chipyard-related project and am bumping chipyard versions.

@sagark sagark merged commit 8c56a5f into main Jun 15, 2022
@jerryz123 jerryz123 deleted the firesim-no-mem branch October 1, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants