Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DefaultClockFrequencyKey rounding #1201

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Fix DefaultClockFrequencyKey rounding #1201

merged 1 commit into from
Sep 1, 2022

Conversation

sant0s12
Copy link
Contributor

@sant0s12 sant0s12 commented Jul 16, 2022

This pull request fixes the frequency rounding for DefaultClockFrequencyKey. Before this change, setting the PBus frequency to a non integer value and using the WithPeripheryBusFrequencyAsDefault trait would make the default clock frequency and the PBus frequency differ when they should be the same.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez abejgonzalez merged commit 8a96f7c into ucb-bar:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants