Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore dotfiles in lookup_srcs makefile function #1218

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

jerryz123
Copy link
Contributor

This makes the find and fd cases match, as fd already ignores dotfiles.
The primary use case is to ignore Emacs lockfiles of the form .#SourceFile.scala.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

This makes the find and fd cases match, as fd already ignores dotfiles.
@jerryz123
Copy link
Contributor Author

Tests are unrelated, will be fixed by #1163

@jerryz123 jerryz123 requested review from sagark and abejgonzalez and removed request for sagark September 5, 2022 17:40
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryz123 jerryz123 merged commit a70a63b into main Sep 6, 2022
@jerryz123 jerryz123 deleted the findignoredot branch September 6, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants