-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump chipyard to integrate mempress #1253
Merged
Merged
Changes from 8 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ead552d
Add mempress submodule
joonho3020 2178b7c
Fix build.sbt to include mempress
joonho3020 94f7a8e
Add mempress config
joonho3020 cf3dbd8
Fix mempress location on build.sbt
joonho3020 5f67a2c
Fix chipyard configs
joonho3020 540a9df
Fix config to use full path
joonho3020 91cebb1
Update tutorial patch file
joonho3020 bbb98a7
Update tutorial patch
joonho3020 02dcc17
Fix tutorial patch to match format
joonho3020 d4e55e5
Add full package path & comments
joonho3020 85825a5
Update RocketConfigs.scala
joonho3020 b75b622
Fix configs for CI
joonho3020 7580bab
Merge upstream
joonho3020 94494cc
Fix L2 cache config
joonho3020 263cd0b
Add Mempress documentation
joonho3020 a156846
Update mempress test code for CI
joonho3020 bcfe0ff
Add mempress test to CI
joonho3020 1177dcc
Fix mempress config name
joonho3020 c8fe9f5
Merge branch 'main' of github.com:ucb-bar/chipyard into mempress-dev
joonho3020 5de3404
Fix typeo
joonho3020 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,14 @@ class TinyRocketConfig extends Config( | |
new freechips.rocketchip.subsystem.With1TinyCore ++ // single tiny rocket-core | ||
new chipyard.config.AbstractConfig) | ||
|
||
class MempressConfig extends Config( | ||
new mempress.WithMemPress ++ | ||
new freechips.rocketchip.subsystem.WithInclusiveCache(nBanks=8, nWays=16, capacityKB=2048) ++ | ||
new chipyard.config.WithExtMemIdBits(7) ++ | ||
jerryz123 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
new freechips.rocketchip.subsystem.WithNMemoryChannels(4) ++ | ||
new chipyard.config.WithSystemBusWidth(128) ++ | ||
new RocketConfig) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please also have the full package path for this as well. |
||
|
||
// DOC include start: FFTRocketConfig | ||
class FFTRocketConfig extends Config( | ||
new fftgenerator.WithFFTGenerator(numPoints=8, width=16, decPt=8) ++ // add 8-point mmio fft at the default addr (0x2400) with 16bit fixed-point numbers. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,17 @@ | ||
diff --git a/build.sbt b/build.sbt | ||
index bbbb8251..b7adcb73 100644 | ||
index ec36a85f..e2b1bd61 100644 | ||
--- a/build.sbt | ||
+++ b/build.sbt | ||
@@ -143,8 +143,8 @@ lazy val testchipip = (project in file("generators/testchipip")) | ||
@@ -146,7 +146,7 @@ lazy val testchipip = (project in file("generators/testchipip")) | ||
|
||
lazy val chipyard = (project in file("generators/chipyard")) | ||
.dependsOn(testchipip, rocketchip, boom, hwacha, sifive_blocks, sifive_cache, iocell, | ||
- sha3, // On separate line to allow for cleaner tutorial-setup patches | ||
+// sha3, // On separate line to allow for cleaner tutorial-setup patches | ||
+/* sha3, // On separate line to allow for cleaner tutorial-setup patches */ | ||
dsptools, `rocket-dsp-utils`, | ||
gemmini, icenet, tracegen, cva6, nvdla, sodor, ibex, fft_generator, | ||
constellation) | ||
.settings(libraryDependencies ++= rocketLibDeps.value) | ||
@@ -189,11 +189,11 @@ lazy val sodor = (project in file("generators/riscv-sodor")) | ||
constellation, mempress) | ||
@@ -204,11 +204,11 @@ lazy val sodor = (project in file("generators/riscv-sodor")) | ||
.settings(libraryDependencies ++= rocketLibDeps.value) | ||
.settings(commonSettings) | ||
|
||
|
@@ -21,11 +20,11 @@ index bbbb8251..b7adcb73 100644 | |
- .settings(libraryDependencies ++= rocketLibDeps.value) | ||
- .settings(chiselTestSettings) | ||
- .settings(commonSettings) | ||
+//lazy val sha3 = (project in file("generators/sha3")) | ||
+// .dependsOn(rocketchip, midasTargetUtils) | ||
+// .settings(libraryDependencies ++= rocketLibDeps.value) | ||
+// .settings(chiselTestSettings) | ||
+// .settings(commonSettings) | ||
+/* lazy val sha3 = (project in file("generators/sha3")) */ | ||
+/* .dependsOn(rocketchip, midasTargetUtils) */ | ||
+/* .settings(libraryDependencies ++= rocketLibDeps.value) */ | ||
+/* .settings(chiselTestSettings) */ | ||
+/* .settings(commonSettings) */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you keep the same type of comments |
||
|
||
lazy val gemmini = (project in file("generators/gemmini")) | ||
.dependsOn(testchipip, rocketchip) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a small descriptive comment on what this is doing.