Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VC707 FPGA board #1278

Merged
merged 7 commits into from
Dec 15, 2022
Merged

Conversation

Lorilandly
Copy link

@Lorilandly Lorilandly commented Nov 30, 2022

Related PRs / Issues: resolves #1195

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

This PR adds support for VC707 4gb version. Ppl running the 1gb version will need to change the ram size in Configs.scala and TestHarness.scala. The target will compile with the same procedure shown in the vcu118 section of the Chipyard document. Only UART, JTAG, DDR is wired. I might add the section in the document sometimes later.

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging this PR as long as there is a CI check to at least test that we can generate the Verilog for the VC707. Can you add a test like the other FPGA platforms:

https://github.com/ucb-bar/chipyard/blob/main/.github/scripts/defaults.sh#L34

mapping["arty"]="SUB_PROJECT=arty verilog"
mapping["vcu118"]="SUB_PROJECT=vcu118 verilog"

Once you do that I'll spawn the CI tests and we can merge if everything passes.

Thanks for the contribution!

Comment on lines -6 to -7
import freechips.rocketchip.util._
import freechips.rocketchip.devices.debug._
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a tool to determine whether there are unnecessary imports? or is this done manually?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it partially manually. The metals plugin (for scala) in vscode indicates if an import is missing. If needed ones are removed it will scream. Removed the unused imports while converting the imports to be explicit.

@abejgonzalez
Copy link
Contributor

You still need to update the list here: https://github.com/ucb-bar/chipyard/blob/main/.github/scripts/defaults.sh#L34. Then I'll spawn up the CI.

@abejgonzalez
Copy link
Contributor

@Mergifyio copy main

@mergify
Copy link

mergify bot commented Dec 14, 2022

copy main

✅ Pull request copies have been created

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and CI passes thanks!

@abejgonzalez abejgonzalez merged commit 8e851b0 into ucb-bar:main Dec 15, 2022
@Lorilandly Lorilandly deleted the vc707fpga branch December 15, 2022 14:53
@Lorilandly Lorilandly changed the title Add support for VC707 FPGA board changelog:added Add support for VC707 FPGA board Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Virtex VC707
2 participants