-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for VC707 FPGA board #1278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with merging this PR as long as there is a CI check to at least test that we can generate the Verilog for the VC707. Can you add a test like the other FPGA platforms:
https://github.com/ucb-bar/chipyard/blob/main/.github/scripts/defaults.sh#L34
chipyard/.github/scripts/defaults.sh
Lines 72 to 73 in 6614b29
mapping["arty"]="SUB_PROJECT=arty verilog" | |
mapping["vcu118"]="SUB_PROJECT=vcu118 verilog" |
Once you do that I'll spawn the CI tests and we can merge if everything passes.
Thanks for the contribution!
import freechips.rocketchip.util._ | ||
import freechips.rocketchip.devices.debug._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a tool to determine whether there are unnecessary imports? or is this done manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it partially manually. The metals plugin (for scala) in vscode indicates if an import is missing. If needed ones are removed it will scream. Removed the unused imports while converting the imports to be explicit.
You still need to update the list here: https://github.com/ucb-bar/chipyard/blob/main/.github/scripts/defaults.sh#L34. Then I'll spawn up the CI. |
@Mergifyio copy main |
✅ Pull request copies have been created
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and CI passes thanks!
Related PRs / Issues: resolves #1195
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?This PR adds support for VC707 4gb version. Ppl running the 1gb version will need to change the ram size in
Configs.scala
andTestHarness.scala
. The target will compile with the same procedure shown in the vcu118 section of the Chipyard document. Only UART, JTAG, DDR is wired. I might add the section in the document sometimes later.