Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FireMarshal #1284

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Bump FireMarshal #1284

merged 1 commit into from
Dec 13, 2022

Conversation

abejgonzalez
Copy link
Contributor

Bumps FireMarshal for new build/debug improvements.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez abejgonzalez self-assigned this Dec 12, 2022
@abejgonzalez
Copy link
Contributor Author

@jerryz123 This isn't checked in CI so this is ready for review + merge (The CI breakage is fixed in #1282)

Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's going on with the tests. But it doesn't seem to be related to this.

@abejgonzalez abejgonzalez merged commit cb56f8f into main Dec 13, 2022
@jerryz123 jerryz123 deleted the bump-firemarshal branch February 13, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants