Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail simulations on TSI errors #1288

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Fail simulations on TSI errors #1288

merged 1 commit into from
Dec 15, 2022

Conversation

tymcauley
Copy link
Contributor

Related PRs / Issues:

#1283

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@tymcauley tymcauley mentioned this pull request Dec 15, 2022
Closed
3 tasks
@abejgonzalez
Copy link
Contributor

@Mergifyio copy main

@mergify mergify bot mentioned this pull request Dec 15, 2022
Closed
@mergify
Copy link

mergify bot commented Dec 15, 2022

copy main

✅ Pull request copies have been created

abejgonzalez
abejgonzalez approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abejgonzalez abejgonzalez merged commit 89dbfae into ucb-bar:main Dec 15, 2022
@tymcauley tymcauley deleted the tsi-sim-exit branch December 15, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abejgonzalez abejgonzalez abejgonzalez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tymcauley @abejgonzalez