Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stripped down rocket configs for FireSim testing #1302

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Stripped down rocket configs for FireSim testing #1302

merged 2 commits into from
Jan 6, 2023

Conversation

t14916
Copy link
Contributor

@t14916 t14916 commented Jan 3, 2023 •
edited
Loading

Describing some simpler configs for Rocket for testing FireSim simulation
Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 self-requested a review January 3, 2023 21:48
jerryz123
jerryz123 approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t14916 t14916 force-pushed the tsondhi/stripped_down_rocket_conf branch from 7ec2c6e to ace6c7f Compare January 4, 2023 23:21
@jerryz123
Copy link
Contributor

@t14916 do you want this merged now?

@jerryz123 jerryz123 merged commit 4b60db6 into main Jan 6, 2023
@t14916 t14916 mentioned this pull request Jan 6, 2023
Closed
12 tasks
@t14916 t14916 mentioned this pull request Jan 19, 2023
Merged
16 tasks
@jerryz123 jerryz123 deleted the tsondhi/stripped_down_rocket_conf branch February 13, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryz123 jerryz123 jerryz123 approved these changes

@davidbiancolin davidbiancolin davidbiancolin approved these changes

Assignees
No one assigned
Labels
changelog:omit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t14916 @jerryz123 @davidbiancolin